Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Include m365 prefix and log passed CLI command options #313

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

DevPio
Copy link
Contributor

@DevPio DevPio commented Oct 1, 2024

🎯 Aim

Adding the m365 prefix: The m365 prefix is now included before every CLI command, ensuring that the logged commands accurately reflect what is run in the terminal.

Logging CLI command options: The PR also includes the functionality to log the options passed with each command, providing better transparency and guidance for developers who want to understand the equivalent terminal commands for SPFx Toolkit features.

However, the functionality to set json as the default output for all commands was not implemented, as there are parts of the code that use other output formats, such as md (Markdown). Changing the default output to json globally could break those functionalities.

image

📷 Result

Captura de tela 2024-09-30 124116

Captura de tela 2024-09-30 124152

✅ What was done

  • [] not done
  • done

🔗 Related issue

Closes: #283

@Adam-it Adam-it self-assigned this Oct 4, 2024
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great 👏👏👏
image

@Adam-it
Copy link
Member

Adam-it commented Oct 4, 2024

Good call about the default output 👍

@Adam-it Adam-it merged commit 1017d42 into pnp:dev Oct 4, 2024
Adam-it pushed a commit that referenced this pull request Oct 19, 2024
…313)

## 🎯 Aim

Adding the m365 prefix: The m365 prefix is now included before every CLI
command, ensuring that the logged commands accurately reflect what is
run in the terminal.

Logging CLI command options: The PR also includes the functionality to
log the options passed with each command, providing better transparency
and guidance for developers who want to understand the equivalent
terminal commands for SPFx Toolkit features.

However, the functionality to set json as the default output for all
commands was not implemented, as there are parts of the code that use
other output formats, such as md (Markdown). Changing the default output
to json globally could break those functionalities.

![image](https://github.com/user-attachments/assets/61a93e6a-712f-4122-82fb-f00ae3ce18b7)

## 📷 Result

![Captura de tela 2024-09-30
124116](https://github.com/user-attachments/assets/0dce5b35-2022-4e54-980a-4c318441282f)

![Captura de tela 2024-09-30
124152](https://github.com/user-attachments/assets/eb01d647-8580-4677-912a-ea6af1ae10d2)

## 🔗 Related issue


Closes: #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants