Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡Feature Idea - extensions and webpart samples view #6

Closed
Tracked by #32
, #33 ,  #34
...
Adam-it opened this issue Sep 29, 2022 · 3 comments · Fixed by #39
Closed
Tracked by #32
, #33 ,  #34
...

💡Feature Idea - extensions and webpart samples view #6

Adam-it opened this issue Sep 29, 2022 · 3 comments · Fixed by #39
Assignees
@Adam-it
Labels
⭐ enhancement New feature or request 💬 needs discussion 👨‍💻work in progress I am working on it

Comments

@Adam-it
Copy link
Member

Adam-it commented Sep 29, 2022 •
edited
Loading

💡 Idea

I was wondering maybe since the extension already allows to create webpart, extensions ect.

image

And we do have a lot of great community samples for those maybe we should create similar sample views for webparts and extensions like we have for the adaptive cards.

.... or is this out of scope for this extension 😉?
@estruyf
Copy link
Member

estruyf commented Sep 30, 2022

We also thought about it, but first focus would be Viva Connections, next we can see what we'll add more or how to bring in other experiences.

@Adam-it
Copy link
Member Author

Adam-it commented Sep 30, 2022

Great, if you will be looking for additional pair of hands to share work I would love to help out and learn 😉.
If you want to start discussing the features to create some detail plan and point out what would be the first step to make it happen I am also all in 🤩

@Adam-it Adam-it added the 👨‍💻work in progress I am working on it label May 3, 2023
@Adam-it Adam-it self-assigned this May 3, 2023
This was referenced May 4, 2023
Closed
Closed
Closed
Merged
Adam-it added a commit that referenced this issue May 7, 2023
@Adam-it
Adds saving sample data (#36)
f531b23 
## 🎯 Aim

The aim of this PR is to add automotive support in gathering sample data
of ACES and SPFx extensions, libraries and webparts. The PR will add a
new workflow scheduled for Saturday to run a ps script that concats all
sample.json files from spfx-dev-fx-webpart/extension/component/aces pnp
repos and store them in a new data folder in vscode-viva repo (this
folder is not included in the extension file). Then those are used when
fetched to build sample views

## 📷 Result


![image](https://user-images.githubusercontent.com/58668583/236665094-416a6cd3-342f-4e6d-a2ba-0506248d0cad.png)

## ✅ What was done

- [X] added ps script to get all sample.json files form pnp sample repos
- [X] added a gh action workflow scheduled that will run the scripts
- [X] updated vscodeignore file

## 🔗 Related issue

Related: #6
@Adam-it Adam-it mentioned this issue May 7, 2023
Merged
2 tasks
Adam-it added a commit that referenced this issue May 7, 2023
@Adam-it
Fixup for sample pipeline (#37)
aec8ec2 
## 🎯 Aim

The aim is to add small fixup in sample pipeline

## ✅ What was done

- [X] Updated sample pipeline yml to pass workspace path and update
script to use it
- [X] Extended gitignore

## 🔗 Related issue

Related: #6
@Adam-it
Copy link
Member Author

Adam-it commented May 7, 2023 •
edited
Loading

@Adam-it Adam-it mentioned this issue May 9, 2023
Merged
6 tasks
Adam-it added a commit that referenced this issue May 13, 2023
@Adam-it
Adds SPFx support (#39)
3557213 
## 🎯 Aim

The aim of this PR is to add SPFx support to the extension. Allowing to
create project by SPFx webpart or extension sample and extending the
create project flow to allow SPFx project creation.

## 📷 Result


![image](https://github.com/pnp/vscode-viva/assets/58668583/03d8072d-b17e-4080-9c4c-f12e457f1c1c)

![image](https://github.com/pnp/vscode-viva/assets/58668583/43369ab9-b40d-42f0-b146-bdaa951bb39a)


## ✅ What was done

- [X] updated samples to add a modified date
- [X] modified welcome experience to add SPFx samples options
- [X] modified commands to add SPFx samples options
- [X] added support to show SPFx webpart and extensions samples
- [X] modified the scaffolding to allow creating SPFx projects as well
- [x] extended readme

## 🔗 Related issue

Related: #34
Closes: #6
Closes: #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
⭐ enhancement New feature or request 💬 needs discussion 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds SPFx support
2 participants
@estruyf @Adam-it