You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that SPFx toolkit has a glitch that even though the status command returns that I am logged in, the first command to get the app catalogs from my tenant requires me to sign in which is only visible in the output window. This leads to a state were I am not logged in, I don't see anything in the account and app catalog view, but I also don't see the sign-in button. We should fix it up.
From what i checked the token expired and I need to resign to refresh it. This is fine but:
first is the above described problem, I don't see the sign it or out button, I need to 'manually' sign out using the command palette in VS Code and then I am able to relogin
in global handle of any CLI command execution we need to add logic that when a login message will get present we should present a notify to the user to relogin to your tenant and sign out user totally and show like initial state
Yesterday I managed to repro this on branch from issue #342 and it turned out this bug will be solved as well as it will by default open the user browser to reauth when using browser auth method
## π― Aim
The aim is to improve and simplify login behavior for SPFx Toolkit and try to
fixup a strange issue with login output when cli command is executed.
## β What was done
- [x] updated login method from device code to browser to simplify the
process
- [x] added saving clientId and tenantId to the global state
## π Related issue
Closes#342, #374
## π― Aim
The aim is to improve and simplify login behavior for SPFx Toolkit and try to
fixup a strange issue with login output when cli command is executed.
## β What was done
- [x] updated login method from device code to browser to simplify the
process
- [x] added saving clientId and tenantId to the global state
## π Related issue
Closes#342, #374
β Priority
(Medium)π’ I'm annoyed but I'll live
π Describe the bug
I noticed that SPFx toolkit has a glitch that even though the status command returns that I am logged in, the first command to get the app catalogs from my tenant requires me to sign in which is only visible in the output window. This leads to a state were I am not logged in, I don't see anything in the account and app catalog view, but I also don't see the sign-in button. We should fix it up.
From what i checked the token expired and I need to resign to refresh it. This is fine but:
first is the above described problem, I don't see the sign it or out button, I need to 'manually' sign out using the command palette in VS Code and then I am able to relogin
in global handle of any CLI command execution we need to add logic that when a login message will get present we should present a notify to the user to relogin to your tenant and sign out user totally and show like initial state
π£ Steps To Reproduce
it happens every time the token expires
π Expected behavior
should logout the user
π· Screenshots
No response
βSharePoint Framework Toolkit version
latest
βNode.js version
No response
π€ Additional context
Follow up to #342
The text was updated successfully, but these errors were encountered: