Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug report: Tenant-wide Extensions Not Loading by Default #317

Closed
Saurabh7019 opened this issue Oct 6, 2024 · 5 comments Β· Fixed by #320
Closed

🐞 Bug report: Tenant-wide Extensions Not Loading by Default #317

Saurabh7019 opened this issue Oct 6, 2024 · 5 comments Β· Fixed by #320
Assignees
Labels
🐞 bug Something isn't working πŸ‘¨β€πŸ’»work in progress I am working on it

Comments

@Saurabh7019
Copy link
Contributor

⭐ Priority

(Low)☹️ Something is a little off

πŸ“ Describe the bug

The tenant-wide extensions are not loading as expected when the setting showTenantWideExtensions is using its default value (true).

πŸ‘£ Steps To Reproduce

  1. Use the extension with the default settings (do not manually update showTenantWideExtensions in settings).
  2. Observe that tenant-wide extensions are not loaded.

πŸ“œ Expected behavior

Tenant-wide extensions should load by default when the showTenantWideExtensions setting is true.

πŸ“· Screenshots

image

❓SharePoint Framework Toolkit version

4.1.1

❓Node.js version

v20.9.0

πŸ€” Additional context

No response

@Saurabh7019 Saurabh7019 added the 🐞 bug Something isn't working label Oct 6, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 6, 2024

@Saurabh7019 and if you click on refresh view button in the upper right corner of this panel? Or refresh the account view?

@Saurabh7019
Copy link
Contributor Author

Refreshing isn't resolving the issue. Both showTenantWideExtensions and showServiceIncidentList settings are not working. It requires a code fix as you can see below:

image

@Adam-it
Copy link
Member

Adam-it commented Oct 6, 2024

thanks for the heads up and investigation. Just had a quick check and in my case seems to be working perfectly fine πŸ€”
image

never the less I think I will double check the code and try to check why you have string there instead of boolean. It seems somewhere we are loosing types πŸ€·β€β™‚οΈ

@Adam-it Adam-it self-assigned this Oct 6, 2024
@Adam-it Adam-it linked a pull request Oct 7, 2024 that will close this issue
1 task
Adam-it added a commit that referenced this issue Oct 7, 2024
## 🎯 Aim

The aim is to do a bit of refactor to ensure correct types when
retrieving extension settings

## πŸ“· Result

![image](https://github.com/user-attachments/assets/c5407994-d234-43ec-8da3-fd4fc0ef2287)

## βœ… What was done

- [X] added typing

## πŸ”— Related issue

Closes: #317
@Adam-it
Copy link
Member

Adam-it commented Oct 7, 2024

The PR with the fix has been merged. A pre-release with this fix will be live shortly

@Adam-it Adam-it closed this as completed Oct 7, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 8, 2024

@Saurabh7019 sorry yesterday I doze off on the laptop and forgot to perform a pre-release with this fix πŸ™
I did one just now https://github.com/pnp/vscode-viva/actions/runs/11230480092/job/31217916362
should be present on VS Code marketplace within 5-10 min

Adam-it added a commit that referenced this issue Oct 19, 2024
## 🎯 Aim

The aim is to do a bit of refactor to ensure correct types when
retrieving extension settings

## πŸ“· Result

![image](https://github.com/user-attachments/assets/c5407994-d234-43ec-8da3-fd4fc0ef2287)

## βœ… What was done

- [X] added typing

## πŸ”— Related issue

Closes: #317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working πŸ‘¨β€πŸ’»work in progress I am working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants