Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 [Bug]: Wrong version of node 18 is validated. Should be >= 18.17.1 #129

Closed
Adam-it opened this issue Oct 29, 2023 · 0 comments
Closed

🐞 [Bug]: Wrong version of node 18 is validated. Should be >= 18.17.1 #129

Adam-it opened this issue Oct 29, 2023 · 0 comments
Assignees
@Adam-it
Labels
🐞 bug Something isn't working
Milestone
v2.2

Comments

@Adam-it
Copy link
Member

Adam-it commented Oct 29, 2023

📝 Describe the bug

we validate wrong version of node 18. Currently we validate 18.12
https://github.com/pnp/vscode-viva/blob/340a79c01ed6fd0ac8c320f45dea3fa138a5b08b/src/services/Dependencies.ts#L11C47-L11C47

but should validate >= 18.17.1

📜 Expected behavior

Should validate for node >= 18.17.1

📷 Screenshots

image

💻 Desktop (please complete the following information):

  • Version: 2.1
@Adam-it Adam-it added the 🐞 bug Something isn't working label Oct 29, 2023
@Adam-it Adam-it self-assigned this Oct 29, 2023
@Adam-it Adam-it added this to the v2.2 milestone Oct 29, 2023
@Adam-it Adam-it mentioned this issue Oct 30, 2023
Merged
3 tasks
Adam-it added a commit that referenced this issue Oct 30, 2023
@Adam-it
Fix node validation and grant api action. Closes #129 (#130)
6a5267d 
## 🎯 Aim

Fixup in validating node version and grant api action.

## ✅ What was done

- [X] changed the version of node 18 to be validated
- [X] fixup in grant api action
- [X] prepared pre-release

## 🔗 Related issue

Closes: #129
@Adam-it Adam-it closed this as completed Oct 30, 2023
Adam-it added a commit that referenced this issue Nov 11, 2023
@Adam-it
Fix node validation and grant api action. Closes #129 (#130)
d02963f 
## 🎯 Aim

Fixup in validating node version and grant api action.

## ✅ What was done

- [X] changed the version of node 18 to be validated
- [X] fixup in grant api action
- [X] prepared pre-release

## 🔗 Related issue

Closes: #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
1 participant
@Adam-it