Fix root site org asset library showing no items in file picker #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When the file picker is used to pick files from an organizational asset library on the SharePoint root site, no files are shown. - Also fix an error in the _parseOrgAssetsLibraryItem function, which causes the absoluteUrl property to lack one / after the root SharePoint URL (e.g. "https://TENANT.sharepoint.comOrganizational Media Library" or "https://TENANT.sharepoint.comsites/OrgAssetsSite/Branding images"). Since this is faulty for org asset libraries on ALL sites, I don't think this property is used, otherwise it would have caused problems already. Explanation of error in file picker of organizational asset library: 1. The relative url of the root site is /, which causes a / to still be present in the library name, after removal of the site relative url. 2. This is turn causes the library name to be an empty string after splitting the library name on /. 3. When building the API request URL for retrieving the organizational assets library items, the library name is therefore missing from the listFullUrl query parameter. - In addition to this, the listFullUrl query parameter can't contain two slashes in front of the library name (also causes the request to fail). - This error would also happen if the site server relative url (_orgAssetsLibraryServerRelativeSiteUrl) starts with a slash.
joaojmendes
added
the
status:fixed-next-drop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
What's in this Pull Request?
Explanation of the error in file picker of organizational asset library:
Screenshots / GIFs
File picker error
Left side has a org. assets library on a site under /sites/, while the right one has one on the root SharePoint site. The gifs are roughly 1,5 minutes long.
Showcasing the current behavior, stepping through the code and showing property values.
Showcasing the fixed behavior, stepping through the code and showing property values.
_parseOrgAssetsLibraryItem
Showing faulty absoluteUrl property on the org asset library, when retrieving from the root SharePoint site.
Showing faulty absoluteUrl property on the org asset library, when retrieving from a site under /sites/.
Showing fixed property.