Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: adds panelProps property to collection data to have control … #546

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

c-eiser13
Copy link
Contributor

@c-eiser13 c-eiser13 commented Mar 2, 2023

Q A
Bug fix? [ ]
New feature? [ x]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

This PR adds a new prop to PropertyFieldCollectionData called panelProps with type IPanelProps so we can have control over various aspects of the underlying panel, especially the size. I've updated the docs for this property if approved, I can create a PR for that change as well.

@c-eiser13
Copy link
Contributor Author

Apologies on the formatting of the .tsx, prettier did it's thing before I realized it. Only change was here
image
If I need to re-submit without formatting, let me know, thanks!

@AJIXuMuK AJIXuMuK merged commit 6dd95d4 into pnp:dev Mar 12, 2023
@AJIXuMuK
Copy link
Collaborator

Thank you @c-eiser13 for the change!
But please, next time disable prettier you're using before creating a PR.
There are some unnecessary changes.

@AJIXuMuK AJIXuMuK modified the milestones: 3.14.0, 3.13.0 Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants