Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldFilePicker - Site Tab - Does not scroll if many libraries #525

Closed
2 tasks
krainer opened this issue Dec 15, 2022 · 6 comments · Fixed by #538
Closed
2 tasks

PropertyFieldFilePicker - Site Tab - Does not scroll if many libraries #525

krainer opened this issue Dec 15, 2022 · 6 comments · Fixed by #538
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@krainer
Copy link

krainer commented Dec 15, 2022

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

  • Enhancement
  • [ X ] Bug
  • Question

Version

Please specify what version of the library you are using: [latest]

Expected / Desired Behavior / Question

Component: PropertyFieldFilePicker

When a site contains a large number of document libraries, and the "Site" tab is selected, is is expected that the end user cal scroll through all document libraries and select the required one

Observed Behavior

When a site contains a large number of document libraries, and the "Site" tab is selected, then the screen will not scroll and thereby not show all items

Steps to Reproduce

  1. Create 20-25 document libraries (empty libraries are fine) in a site collection
  2. Deploy the "propertyControlsTest" web part in the site collection (ur use gulp serve)
  3. Open the web part properties
  4. Select "File Picker" below the "People, Terms, Files, Role Definition" headline
  5. Select the "Site" tab
  6. If all document libraries are shown, resize the window so it is smaller
  7. The last document libraries are not available to selected

I will submit a PR with a fix

@ghost
Copy link

ghost commented Dec 15, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@krainer
Copy link
Author

krainer commented Jan 2, 2023

bump

@joelfmrodrigues
Copy link
Collaborator

@krainer this has now been merged. Would you be interested in sending a PR with the same fix to the other repository with the reusable controls?

@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Jan 4, 2023
@joelfmrodrigues joelfmrodrigues added this to the 3.12.0 milestone Jan 4, 2023
@krainer
Copy link
Author

krainer commented Jan 4, 2023

@joelfmrodrigues let me take a look at it as well

@joelfmrodrigues
Copy link
Collaborator

@krainer many thanks! Hopefully should be the same code changes

krainer added a commit to krainer/sp-dev-fx-controls-react that referenced this issue Jan 4, 2023
FilePicker Control - Site Tab - When many document libraries exists, the screen will not scroll and thereby all libraries are not available - same issue as in the property controls (pnp/sp-dev-fx-property-controls#525)
@krainer
Copy link
Author

krainer commented Jan 4, 2023

@joelfmrodrigues -> PR added for the react project:

pnp/sp-dev-fx-controls-react#1413

@AJIXuMuK AJIXuMuK mentioned this issue Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants