Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock connection to SharePoint 2013 #4622

Merged
merged 5 commits into from
Dec 15, 2024

Conversation

pkbullock
Copy link
Contributor

@pkbullock pkbullock commented Dec 8, 2024

Transformation On Prem flag added

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes #4609

What is in this Pull Request ?

Flag to bypass client id check on transformation on-premises.

Tested with SP2013

Transformation On Prem flag added
@pkbullock
Copy link
Contributor Author

pkbullock commented Dec 8, 2024

Not sure why this build is failing here, but fine on my local machine. I've only changed one line lol. Am i missing something?

@pkbullock
Copy link
Contributor Author

@gautamdsheth - this is most odd. Still fails.

pkbullock added a commit to pkbullock/powershell that referenced this pull request Dec 14, 2024
Want to work around a build failure issue, since the change was only one line, want to do a repeat change and see if the build action works. 

Ref pnp#4622 pnp#4609
@pkbullock pkbullock marked this pull request as draft December 14, 2024 09:42
@pkbullock
Copy link
Contributor Author

@gautamdsheth - I'm stuck here, is there a dependency I am missing in GitHub, seems like it cannot build due to a missing Graph dependency. The only change I have made to this PR is one line, Boolean check which doesn't change any Graph dependencies. All local builds work.

@pkbullock pkbullock marked this pull request as ready for review December 14, 2024 10:44
@gautamdsheth gautamdsheth merged commit eab639e into pnp:dev Dec 15, 2024
1 of 2 checks passed
@gautamdsheth
Copy link
Collaborator

@pkbullock - yeah, must be something weird with the GH action. Tested it locally, builds fine, merged it. Thank you !

@pkbullock
Copy link
Contributor Author

Awesome, thank you @gautamdsheth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect-PnPOnline - On Prem Tranformation
2 participants