Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SiteId to the model since it was missing #4527

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

fthorild
Copy link
Contributor

@fthorild fthorild commented Nov 7, 2024

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

SiteId was not included in the SPOSite model and therefore not possible to get back even though it is there under the covers. In my case I needed to merge some stuff with the SP usage reports which only has SiteId as a key. This is mentioned way back in #36

What is in this Pull Request ?

Two lines of code in the SPOSite object to include the SiteId

@KoenZomers
Copy link
Collaborator

Thanks for your contribution @fthorild, much appreciated!

@KoenZomers KoenZomers merged commit bf8d384 into pnp:dev Nov 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants