Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude pre-release versions in version check for stable releases #4453

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

jackpoz
Copy link
Contributor

@jackpoz jackpoz commented Oct 19, 2024

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes #4408 after next release.

What is in this Pull Request ?

Exclude pre-release versions in version check for stable releases by appending $filter=IsPrerelease eq false to the PowerShell Gallery feed url in those cases.
Nightly releases will continue to include pre-releases like they do already now.

This is the message displayed when simulating version 2.11.0 using url https://www.powershellgallery.com/api/v2/FindPackagesById()?id='PnP.PowerShell'&$top=10&$orderby=Created%20desc&$filter=IsPrerelease%20eq%20false :
Screenshot 2024-10-19 180334

This is the message displayed when using a nightly build using url https://www.powershellgallery.com/api/v2/FindPackagesById()?id='PnP.PowerShell'&$top=10&$orderby=Created%20desc :
image

@gautamdsheth gautamdsheth merged commit 5356ef0 into pnp:dev Oct 19, 2024
3 checks passed
@gautamdsheth
Copy link
Collaborator

Thanks @jackpoz , merged it !!
Much appreciated .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Latest version in version check is nightly and not stable one
2 participants