Fix Add-PnPDataRowsToSiteTemplate setting KeyColumn to null #4325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes pnp/pnpframework#1020
What is in this Pull Request ?
This PR fixes Add-PnPDataRowsToSiteTemplate setting KeyColumn to null when the -KeyColumn parameter is not passed. It also fixes the case of -KeyColumn parameter value being ignored.
The old code was updating
listInstance.DataRows.KeyColumn
only when the-KeyColumn
parameter was null, but it should update it only when it's not null.How to reproduce steps: