Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Get-PnPTeamsChannel MembershipType return value #4054

Merged
merged 5 commits into from
Jun 30, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'dev' into fixes/GetTeamsChannelsShared
KoenZomers authored Jun 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 7c198df9769516e8660bb88db8502a805c7d3cbb
6 changes: 4 additions & 2 deletions src/Commands/Utilities/TeamsUtility.cs
Original file line number Diff line number Diff line change
@@ -639,7 +639,8 @@
{
{ "Prefer", "include-unknown-enum-members" }
};
var channel = await GraphHelper.GetAsync<TeamChannel>(connection, $"{(useBeta ? "beta" : "v1.0")}/teams/{groupId}/channels/{channelId}", accessToken, additionalHeaders: additionalHeaders);

var channel = GraphHelper.Get<TeamChannel>(cmdlet, connection, $"{(useBeta ? "beta" : "v1.0")}/teams/{groupId}/channels/{channelId}", accessToken, additionalHeaders: additionalHeaders););

Check failure on line 643 in src/Commands/Utilities/TeamsUtility.cs

GitHub Actions / build_dev_branch

} expected

Check failure on line 643 in src/Commands/Utilities/TeamsUtility.cs

GitHub Actions / build_dev_branch

} expected
return channel;
}

@@ -649,7 +650,8 @@
{
{ "Prefer", "include-unknown-enum-members" }
};
var collection = await GraphHelper.GetResultCollectionAsync<TeamChannel>(connection, $"{(useBeta ? "beta" : "v1.0")}/teams/{groupId}/channels", accessToken, additionalHeaders: additionalHeaders);

var collection = GraphHelper.GetResultCollection<TeamChannel>(cmdlet, connection, $"{(useBeta ? "beta" : "v1.0")}/teams/{groupId}/channels", accessToken, additionalHeaders: additionalHeaders);
return collection;
}

You are viewing a condensed version of this merge commit. You can view the full changes here.