Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdlet remove-pnpcontainertype and minor changes. closes #3670. #3689

Merged
merged 6 commits into from
Jan 20, 2024
Merged

Cmdlet remove-pnpcontainertype and minor changes. closes #3670. #3689

merged 6 commits into from
Jan 20, 2024

Conversation

reshmee011
Copy link
Contributor

https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md

Type

  • New Feature

Related Issues?

closes #3670

What is in this Pull Request ?

New files
documentation\Remove-PnPContainerType.md
src\Commands\Admin\RemoveContainerType.cs

Updated files
documentation\Remove-PnPContainer.md : correct a type
src\Commands\Admin\GetContainer.cs : add property ValueFromPipeline = true to parameter Identity
src\Commands\Admin\GetDeletedContainer.cs : remove extra line
src\Commands\Admin\RemoveContainer.cs : add property ValueFromPipeline = true to Identity

@gautamdsheth
Copy link
Collaborator

@reshmee011 - can you try to rebase this with the latest dev branch ? I tried but looks like it’s not working which is causing build issues.

Have fixed the dev branch but not able to push the latest from dev into your branch unfortunately.

@reshmee011
Copy link
Contributor Author

@gautamdsheth : I have got latest changes into the branch, it is finally building. Many thanks for your help on this.

@gautamdsheth gautamdsheth merged commit f36f7fa into pnp:dev Jan 20, 2024
3 checks passed
@gautamdsheth
Copy link
Collaborator

thanks @reshmee011 , much appreciated !!

@reshmee011 reshmee011 deleted the deletecontainertype branch January 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New cmdlet to delete trial container SPOContainerType :remove-pnpcontainertype
2 participants