Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/recyclebin paging #2472

Merged
merged 6 commits into from
Oct 17, 2022
Merged

Conversation

koskila
Copy link
Contributor

@koskila koskila commented Oct 16, 2022

Implement paging for getting recycle bin items.

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes #1598

What is in this Pull Request ?

Abstracts getting recycle bin items to a new helper class ("utility) and implements paging. The code is a bit verbose, but I hope you can deal with it - I can of course work on it further if need be :)

Note - I had to remove the ordering of the items (by deleted date, desc) to make paging work. It could be implemented on the client-side, if we want to?

@koskila koskila mentioned this pull request Oct 16, 2022
3 tasks
@gautamdsheth gautamdsheth merged commit 783b352 into pnp:dev Oct 17, 2022
@gautamdsheth
Copy link
Collaborator

Awesome stuff @koskila, thank you so much, merged it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants