Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullDereferenceException in Add-PnPTeamsTab #2405

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

jackpoz
Copy link
Contributor

@jackpoz jackpoz commented Oct 1, 2022

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

No linked issues

What is in this Pull Request ?

Similar to #2156 and #2338 , this PR fixes NullDereferenceExceptions thrown when calling Add-PnPTeamsTab without specifying -Type parameter but later selecting a Type that requires dynamic parameters.

The affected -Type options are:

  • Word
  • Excel
  • PowerPoint
  • PDF
  • Custom

Tests

Old behavior:
image

New behavior:
image

Fix NullDereferenceException in Add-PnPTeamsTab when not including -Type parameter and specifying Word/Excel/PowerPoint/PDF/Custom as Type later on
@gautamdsheth gautamdsheth merged commit 97697e9 into pnp:dev Oct 1, 2022
@gautamdsheth
Copy link
Collaborator

Thanks @jackpoz for fixing this. Much appreciated.

@jackpoz jackpoz deleted the fixes/addteamstab-nullexception branch December 4, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants