Feature: improved adding users to Teams

CHANGELOG.md

@@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ### Changed
 
+- Improved `Add-PnPTeamsUser` cmdlet. The cmdlet executes faster and we can now add users in batches of 200. [#1548](https://github.com/pnp/powershell/pull/1548)
 - The `Move\Remove\Rename-PnPFolder` cmdlets now support pipebinds.
 - Changed `Add-PnPDataRowsToSiteTemplate`, it will return a warning if user(s) are not found during list item extraction. Earlier it used to throw error and stop extraction of list items.
 - Disabling telemetry collection now requires either setting the environment variable or creating the telemetry file ([documentation](https://pnp.github.io/powershell/articles/configuration.html)) [#1504](https://github.com/pnp/powershell/pull/1504)

src/Commands/Utilities/TeamsUtility.cs

@@ -405,17 +405,22 @@ public static async Task AddUserAsync(HttpClient httpClient, string accessToken,
 
         public static async Task AddUsersAsync(HttpClient httpClient, string accessToken, string groupId, string[] upn, string role)
         {
-            var chunks = BatchUtility.Chunk(upn.Select(u => GetUserGraphUrlForUPN(u)), 20);
-            foreach (var chunk in chunks)
+            var teamChannelMember = new List<TeamChannelMember>();
+            if(upn != null && upn.Length > 0)
             {
-                var results = await BatchUtility.GetPropertyBatchedAsync(httpClient, accessToken, chunk.ToArray(), "/{0}", "id");
-                var teamChannelMember = new List<TeamChannelMember>();
-                foreach (var userid in results.Select(r => r.Value))
+                foreach (var user in upn)
                 {
-                    teamChannelMember.Add(new TeamChannelMember() { Roles = new List<string> { role }, UserIdentifier = $"https://{PnPConnection.Current.GraphEndPoint}/v1.0/users('{userid}')" });
+                    teamChannelMember.Add(new TeamChannelMember() { Roles = new List<string> { role }, UserIdentifier = $"https://{PnPConnection.Current.GraphEndPoint}/v1.0/users('{user}')" });
                 }
-                await GraphHelper.PostAsync(httpClient, $"v1.0/teams/{groupId}/members/add", new { values = teamChannelMember }, accessToken);
-            }
+                if (teamChannelMember.Count > 0)
+                {
+                    var chunks = BatchUtility.Chunk(teamChannelMember, 200);
+                    foreach (var chunk in chunks.ToList())
+                    {
+                        await GraphHelper.PostAsync(httpClient, $"v1.0/teams/{groupId}/members/add", new { values = chunk.ToList() }, accessToken);
+                    }
+                }
+            }            
         }
 
         public static async Task<List<User>> GetUsersAsync(HttpClient httpClient, string accessToken, string groupId, string role)