💡New command : tenant report settings set - closes #6247

[NishkalankBezawada]

New command : tenant report settings set - closes #6247

Explanation

This command can be used to update (adminReportSettings) tenant-level settings for Microsoft 365 reports.
Please refer to the Graph documentation page.

Usage

m365 tenant report settings set [options]

test screens

Below has set --hideUserInformation to false

below is the screen from the Admin center

Below has set --hideUserInformation to true

below is the screen from the Admin center

Below screen shows further validations

Thanks,
Nish

[milanholemans]

Thanks @NishkalankBezawada, we'll try to review it ASAP.

[martinlingstuyl]

Hi @NishkalankBezawada, I ran the tests that we usually do on PR's. There's a couple of issue though, or so it appears. Could you like at them and fix them in your code? You may want to run npm run test afterwards, to ensure the tests are running OK on your machine.

Let me know if you have questions.

[NishkalankBezawada]

Hi @NishkalankBezawada, I ran the tests that we usually do on PR's. There's a couple of issue though, or so it appears. Could you like at them and fix them in your code? You may want to run npm run test afterwards, to ensure the tests are running OK on your machine.

Let me know if you have questions.

Hey @martinlingstuyl

Thanks for reviewing. Since this is my first contribution to the repository, I might have missed a few things. I will surely check on this in the evening, and send in for your review.

Thanks,
Nish

[martinlingstuyl]

Yes it's me 😄!

You can always check our contribution documentation, which is quite good. Also when it's about unit tests.
https://pnp.github.io/cli-microsoft365/contribute/contributing-guide

If you've got any questions, let me know 🚀

[NishkalankBezawada]

Yes it's me 😄!

You can always check our contribution documentation, which is quite good. Also when it's about unit tests. https://pnp.github.io/cli-microsoft365/contribute/contributing-guide

If you've got any questions, let me know 🚀

Hey @martinlingstuyl, This pretty much helped me.

Will be sending a new review soon 🚀

Thanks,
Nish

[NishkalankBezawada]

Hey @martinlingstuyl,

ran the tests 😄 and also updated validations. now ready for your review 🚀

Thanks,
Nish

[martinlingstuyl]

Hi nish, let's look at a couple of comments before we merge this. You've made a good start with this. A lot of my comments are actually just styling. :-)

[NishkalankBezawada]

Hi nish, let's look at a couple of comments before we merge this. You've made a good start with this. A lot of my comments are actually just styling. :-)

Hey @martinlingstuyl

I'm sorry, I couldnt check this yesterday, was a bit sick. Now I have resolved the suggestions and ran the test again,

Thanks,
Nish

[martinlingstuyl]

Almost done... some last comments nish! And something we need to discuss from the specs...

[martinlingstuyl]

Very nice Nish, There are a couple of minor comments open, which I'll fix while merging.

[NishkalankBezawada]

Very nice Nish, There are a couple of minor comments open, which I'll fix while merging.

Hey @martinlingstuyl

Do you want me to do these changes? If so, I can do that. Its all about learning.

//Nish

[martinlingstuyl]

Feel free! I'll merge it soon, if the changes aren't done I'll pick them up.

[NishkalankBezawada]

Feel free! I'll merge it soon, if the changes aren't done I'll pick them up.

Hey @martinlingstuyl

Just pushed the final changes.

Thanks,
Nish

[martinlingstuyl]

Hi Nish,

thanks, I'll give it a last look.
Just FYI: if you've resolved a comment, do mark the comment as resolved, that makes it easier for me to see whats been fixed.

[martinlingstuyl]

Very nice Nish, There are

[martinlingstuyl]

Merged manually, thank you! 🚀