New command: m365 pp website get, Closes #6259 #6486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution @nicodecleyre. Could you fix the workflow failure? |
martinlingstuyl
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Couple of comments @nicodecleyre, but on the whole this looks good!
martinlingstuyl
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Looks good to me @nicodecleyre! I'll merge it sometime soon!
| : The WebSite Id (GUID) of the website to retrieve. Specify either `url`, `name` or `id`. | ||
|
|
||
| `-e, --environmentName <environmentName>` | ||
| : The name of the environment from which to retrieve Power Pages website from. |
There was a problem hiding this comment.
Suggested change
| : The name of the environment from which to retrieve Power Pages website from. | |
| : The name of the environment from which to retrieve the Power Pages website. |
| public getRefinedSchema(schema: typeof options): z.ZodEffects<any> | undefined { | ||
| return schema | ||
| .refine(options => [options.url, options.id, options.name].filter(x => x !== undefined).length === 1, { | ||
| message: `Either url, id or name is required, but not multiple.` |
There was a problem hiding this comment.
Suggested change
| message: `Either url, id or name is required, but not multiple.` | |
| message: `Specify either url, id or name, but not multiple.` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6259