Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Improve error messages when a valid certificate cannot be loaded from the given path #2888

Merged

Conversation

jackpoz
Copy link
Contributor

@jackpoz jackpoz commented Sep 3, 2020

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/PnP-PowerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Improves the troubleshooting of #2879

What is in this Pull Request ?

This PR improves the error messages displayed when a valid certificate cannot be loaded from the given path.

Handled cases:

  1. The path is a folder (before it would say "Access to Path 'C:\Temp' is denied")
    image

  2. The path doesn't exist at all
    image

  3. The path is an empty file (before it would say "Array may not be empty or null")
    image

Guidance

  • You can delete this section when you are submitting the pull request.*
  • Please update this PR information accordingly. We use this as part of our release notes in monthly communications.
  • Please target your PR to Dev branch. If you do not target the Dev branch we will not accept this PR.

@erwinvanhunen
Copy link
Member

Thanks!

@erwinvanhunen erwinvanhunen merged commit d68d590 into pnp:dev Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants