Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Added a RowLimit parameter to Clear-PnPRecycleBinItem and Restore-PnPRecycleBinItem #2760

Merged
merged 8 commits into from
Jun 29, 2020

Conversation

Professr
Copy link

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Partially fixes #2315

What is in this Pull Request ?

Added a RowLimit parameter to Clear-PnPRecycleBinItem so that it can be used on recycle bins > 5000 items

@Professr Professr changed the title Issue#2315 Issue#2315 - Added a RowLimit parameter to Clear-PnPRecycleBinItem Jun 24, 2020
@Professr
Copy link
Author

Thanks, this codebase is new to me (just started looking at it yesterday) and I didn't want to depart more than necessary from the way RowLimit was handled in Get-PnPRecycleBinItem in case I trod on style guidelines. It looks much cleaner after your commit!

@KoenZomers
Copy link
Collaborator

Nice one @Professr! Thanks for your contribution!

@KoenZomers KoenZomers removed their assignment Jun 24, 2020
@KoenZomers KoenZomers added the status:checked and ready for merge ✔ PR has been checked and is ready for merge label Jun 24, 2020
@KoenZomers KoenZomers changed the title Issue#2315 - Added a RowLimit parameter to Clear-PnPRecycleBinItem Added a RowLimit parameter to Clear-PnPRecycleBinItem and Restore-PnPRecycleBinItem Jun 24, 2020
@KoenZomers KoenZomers linked an issue Jun 24, 2020 that may be closed by this pull request
4 tasks
@erwinvanhunen erwinvanhunen merged commit 4e75e55 into pnp:dev Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:checked and ready for merge ✔ PR has been checked and is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-PnPRecycleBinItem exceeds the list view threshold
4 participants