Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Change to the removal of the certificate from the MachineKeys on Disconnect-PnPOnline #2759

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Change to the removal of the certificate from the MachineKeys on Disconnect-PnPOnline #2759

merged 2 commits into from
Jun 25, 2020

Conversation

KoenZomers
Copy link
Collaborator

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Discussed in #2752

What is in this Pull Request ?

Change to only remove the certificate from the MachineKeys on Disconnect-PnPOnline if the -CertificatePath has been used to connect as it seems to be causing weird side effects to some where it invalidates the private key.

-- PR on hold awaiting confirmation of test discussed in the issue thread --

…ect-PnPOnline if the -CertificatePath has been used to connect
@KoenZomers KoenZomers added the status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. label Jun 24, 2020
@KoenZomers KoenZomers self-assigned this Jun 24, 2020
@KoenZomers KoenZomers marked this pull request as ready for review June 24, 2020 23:03
@KoenZomers KoenZomers removed their assignment Jun 24, 2020
@KoenZomers KoenZomers added status:checked and ready for merge ✔ PR has been checked and is ready for merge and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Jun 24, 2020
@wobba wobba merged commit fbab88a into pnp:dev Jun 25, 2020
@wobba
Copy link
Contributor

wobba commented Jun 25, 2020

Thank you @KoenZomers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:checked and ready for merge ✔ PR has been checked and is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect-PnPOnline throws "Exception has been thrown by the target of an invocation"
3 participants