Fix for Azure Runbook issue #2735
Conversation
…compiled version due to issue with Azure Runbooks not working otherwise
KoenZomers
added
the
status:checked and ready for merge ✔
KoenZomers
added
status:tracked
|
Pulling it back intro draft as I found out this change breaks the Initialize-PnPPowerShellAuthentication cmdlet. |
|
Submitted PR AzureAD/microsoft-authentication-library-for-dotnet#1891 in MSAL hoping to get this fixed there. If they won't allow the fix, we will have to deviate from MSAL and use our own build of MSAL from now on, which would be really unfortunate. |
KoenZomers
changed the title
|
Making this PR available again. It now uses a custom built MSAL. If the PR for MSAL to fix this gets accepted, I will update this PR if it hasn't been merged yet or if it has, will create a new PR to switch from the custom built MSAL library to the official one again. This way we at least can ensure it's fixed in the next release, one way or another. |
KoenZomers
added
status:checked and ready for merge ✔
|
MSAL PR has been merged. Depending on when the next version of MSAL will be released containing this fix, we can replace the custom built MSAL version which is currently in this PR with the official one again. If the next MSAL release doesn't happen before our next release, we'll stick with our custom built MSAL version for our next release and will update it again in a future release. |
|
This PR has been put on hold for now awaiting the 4.16 release of MSAL. |
KoenZomers
removed
the
status:checked and ready for merge ✔
KoenZomers
added
the
status:checked and ready for merge ✔
|
MSAL 4.16 has been released earlier today. Updating this PR to use that. |
Type
Related Issues?
Issue #2726
What is in this Pull Request ?
Updated MSAL to latest version and forced reference to .NET Standard compiled version due to issue with Azure Runbooks not working with PnP Graph cmdlets. Issue can be tracked down to statistical code inside MSAL which in the .NET 4.5 build tries to get the machine IP address:
https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/cdf467b091e0b371deeda99861b5c01a928c504b/src/client/Microsoft.Identity.Client/Platforms/net45/NetDesktopPlatformProxy.cs#L214
which does not work in an Azure Runbook and will fail with:
Unable to find an entry point named 'GetPerAdapterInfo' in DLL 'iphlpapi.dll'Fixed in MSAL through PR AzureAD/microsoft-authentication-library-for-dotnet#1891
Awaiting a new release of MSAL in which this fix is included. In the meantime used a custom compiled build in to get this fixed.
Issue was introduced with this update of PnP PowerShell referencing a new MSAL library on April 1:
e7b2ce9#diff-6c05e73f37aa7d4c0e28014e8985d8c7
A temporary SharePointPnPPowerShellOnline version in which this issue has been resolved is available from here:
SharePointPnPPowerShellOnline.zip
Big thanks to @robinmeure for helping getting to the bottom of this!