Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joss] degree_dist() is a misnomer #136

Open
szhorvat opened this issue Jan 17, 2024 · 1 comment
Open

[joss] degree_dist() is a misnomer #136

szhorvat opened this issue Jan 17, 2024 · 1 comment
Labels
active Work in progress joss

Comments

@szhorvat
Copy link
Contributor

szhorvat commented Jan 17, 2024 •
edited
Loading

Nitpick: The degree_dist() method has a name that is perhaps not the best fit. What this function returns is not a distribution, but a list of degrees. In graph theory this is called a degree sequence, not a degree distribution. What is normally understood as a degree distribution is the fraction of times each degree appears in the degree sequence.

Ref openjournals/joss-reviews#6016
@bonicim
Copy link
Collaborator

bonicim commented Jan 17, 2024

Good point. We will address this name in the next release.

@bonicim bonicim added active Work in progress joss labels Jan 17, 2024
bonicim added a commit that referenced this issue Feb 28, 2024
@bonicim @brendapraggastis
Pull request #136: HYP-365 Silence warnings in tutorials
e59c15c 
Merge in HYP/hypernetx from HYP-365 to develop

* commit 'ace11448282f13b5ee4575641f381079ee4a9938':
  HYP-365 Silence warnings in tutorials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
active Work in progress joss
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szhorvat @bonicim