Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning for <script context="module"> #671

Closed
wants to merge 2 commits into from

Conversation

collinmurch
Copy link

Fixe deprecation warning for <script context="module"> by using <script module> as described here.

Let me know if there's anything else I should change with this MR. Not positive how you want to do the changelogs either, if you give me some pointers I'm happy to take care of it though.

Copy link

changeset-bot bot commented Nov 16, 2024

⚠️ No Changeset found

Latest commit: 66db294

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pngwn
Copy link
Owner

pngwn commented Nov 16, 2024

I'm afraid we can't do this because it is incompatible with version 4 and as such is a breaking change. I don't want any major breaking changes just yet and I don't want to drop support for v4 yet either.

@collinmurch
Copy link
Author

Ah bummer, I understand though. I'm pretty new to Svelte. I'm surprised they're already deprecating it if it's incompatible with Svelte 4 though.

@collinmurch collinmurch changed the title Fixe deprecation warning for <script context="module"> Fix deprecation warning for <script context="module"> Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants