CMake: Correctly handle generated files #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated files depend on other generated files, and this previously resulted in the same custom command output being a dependency of multiple other custom commands without a shared custom targets. Adds a top-level target for each generated file and ensures that commands that depend on generated files also depend on the corresponding custom targets. Per CMake documentation: > Do not list the output in more than one independent target > that may build in parallel or the two instances of the rule > may conflict (instead use add_custom_target to drive the command > and make the other targets depend on that one).
This was referenced Dec 4, 2021
|
@glennrp This merges cleanly into both the |
|
Hi there, support for the "old" xcode build system is going away, and so landing this patch would be really helpful right now. |
Closed
1 task
|
I would welcome your fix in https://github.com/libpng/libpng |
starseeker
added a commit
to BRL-CAD/brlcad
that referenced
this pull request
Aug 19, 2022
It looks as if there's an issue with the CMake code for PNG with modern XCode: PixarAnimationStudios/OpenUSD#1946 pnggroup/libpng#403 This commit makes a stab at adapting the version from libpng/libpng#2 onto our (somewhat simplified) png build. It looks as if libpng doesn't currently have much in the way of an active upstream (no new releases in a number of years), so will need to keep an eye out to see what the eventual solution is.
|
Integrated. Thank you very much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated files depend on other generated files, and this previously resulted in the same custom command output being a dependency of multiple other custom commands without a shared custom targets.
Adds a top-level target for each generated file and ensures that commands that depend on generated files also depend on the corresponding custom targets.
Per CMake documentation:
Fixes #344
Fixes #394