add ability to run with specified TLS Cert and Key files #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
approved these changes
Apr 18, 2018
| @@ -94,6 +94,15 @@ func (s *Server) RunTLS(ctx context.Context, addr string, cert string, key strin | |||
| return s.run(ctx, addr, listenAndServe) | |||
| } | |||
|
|
|||
| // RunTLSWithTLSFiles creates the HTTPS handler based on the certification | |||
| // files that were passed and begins to listen on the specified address. | |||
| func (s *Server) RunTLSWithTLSFiles(ctx context.Context, addr string, certFilePath string, keyFilePath string) error { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement to be made to starter pack uses SSL Cert and Key files created by OpenShift service. We need an easy way to run with file based certificate data.