Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Info msgs to V(2).Info #40

Merged
merged 1 commit into from
Apr 13, 2018
Merged

change Info msgs to V(2).Info #40

merged 1 commit into from
Apr 13, 2018

Conversation

jboyd01
Copy link
Contributor

@jboyd01 jboyd01 commented Apr 12, 2018

I'd like to be able to silence the Info msgs from the broker lib while still seeing my own.

@pmorie
Copy link
Owner

pmorie commented Apr 12, 2018

I'm wondering if a higher level like 3 might be better; 2 is still pretty low.

@pmorie pmorie requested a review from lilic April 12, 2018 18:33
@lilic
Copy link
Collaborator

lilic commented Apr 12, 2018

I am used to seeing 4, but fine with 3 or 2. :)

@jboyd01
Copy link
Contributor Author

jboyd01 commented Apr 12, 2018

I went with 4, thanks

Copy link
Collaborator

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks!

@lilic lilic merged commit cfcc33d into pmorie:master Apr 13, 2018
jboyd01 pushed a commit to jboyd01/osb-broker-lib that referenced this pull request Apr 17, 2018
Implement LastOperation in APISurface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants