Fix unpacking update request #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Should we add test cases to verify that the correct data is getting passed through? |
jmrodri
reviewed
Mar 26, 2018
| planID := vars[osb.VarKeyPlanID] | ||
| if planID != "" { | ||
| osbRequest.PlanID = &planID | ||
| asyncQueryParamVal := r.FormValue(osb.AcceptsIncomplete) |
|
@shawn-hurley Agreed! Adding them now :) |
|
@lilic tells me she's time constrained and won't be able to finish the tests for a couple days. Merging now since I trust her to follow through :) |
jboyd01
pushed a commit
to jboyd01/osb-broker-lib
that referenced
this pull request
Apr 17, 2018
Plumb image parameter through Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #19