implement originating origin identity #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shawn-hurley
commented
Feb 28, 2018
shawn-hurley
commented
- added a interface to the context
- Exposing the concrete classes for casting if wanted
* added a interface to the context * Exposing the concrete classes for casting if wanted
pmorie
reviewed
Feb 28, 2018
pkg/broker/logic.go
Outdated
| Request *http.Request | ||
| Writer http.ResponseWriter | ||
| Request *http.Request | ||
| Identity Identity |
There was a problem hiding this comment.
Note for readers, I'm talking to Shawn in real life, these are notes only.
Take this out for now.
pkg/rest/apisurface.go
Outdated
| @@ -79,9 +80,16 @@ func (s *APISurface) ProvisionHandler(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| glog.Infof("Received ProvisionRequest for instanceID %q", request.InstanceID) | |||
|
|
|||
| identity, err := retrieveOriginatingIdentity(r) | |||
pkg/rest/apisurface.go
Outdated
| c := &broker.RequestContext{ | ||
| Writer: w, | ||
| Request: r, | ||
| Writer: w, |
There was a problem hiding this comment.
Populate the originating identity field of the osb.Xrequest
pkg/broker/user_info.go
Outdated
| return nil, fmt.Errorf("unable decode identity value") | ||
| } | ||
| switch strings.ToLower(platform) { | ||
| case "kubernetes": |
There was a problem hiding this comment.
Make these (in a separate PR, if you please) methods that give you back the right formulation
|
I updated based on the comments and I also took a stab at adding a test case for making sure the Originating Origin Identity is being set. |
pmorie
reviewed
Mar 2, 2018
pkg/rest/apisurface.go
Outdated
| return osbRequest, nil | ||
| } | ||
|
|
||
| func retrieveOriginatingIdentity(r *http.Request) (*osb.OriginatingIdentity, error) { |
There was a problem hiding this comment.
Will you add a godoc comment to this method?
pkg/server/deprovision_test.go
Outdated
| @@ -74,6 +75,20 @@ func TestDeprovision(t *testing.T) { | |||
| Async: true, | |||
| }, | |||
| }, | |||
| { | |||
| name: "deprovision passes originating origin idenity is passed", | |||
|
LGTM, thanks @shawn-hurley |
jboyd01
pushed a commit
to jboyd01/osb-broker-lib
that referenced
this pull request
Apr 17, 2018
add travis badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.