mpir_pmi: Move PMI(x)_Finalize to atexit handler to enable re-init. #6534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
approved these changes
Jun 7, 2023
|
test:mpich/warnings |
Move the call of PMI(x)_Finalize to an atexit handler to keep the connection to the PM open between two consecutive MPI sessions. Unlike the solution implemented in PR pmodels#6337, this solution is generic and does not require changes in the PM's implementation of PMI(x)_Finalize.
|
test:mpich/warnings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the call of PMI(x)_Finalize to an atexit handler to keep the connection to the PM open between two consecutive MPI sessions. Unlike the solution implemented in PR #6337, this solution is generic and does not require changes in the PM's implementation of PMI(x)_Finalize.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.