hydra/mpiexec: check empty command line and fail early #6520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
changed the title
hzhou
changed the title
raffenet
reviewed
May 15, 2023
src/pm/hydra/mpiexec/mpiexec.c
Outdated
| @@ -44,6 +44,10 @@ int main(int argc, char **argv) | |||
|
|
|||
| PMISERV_pg_init(); | |||
|
|
|||
| if (argc == 1) { | |||
| HYDU_ERR_SETANDJUMP(status, HYD_INVALID_PARAM, "command line empty. Try -h for usages.\n"); | |||
There was a problem hiding this comment.
Change is good. Just a suggested change to the help text.
Suggested change
| HYDU_ERR_SETANDJUMP(status, HYD_INVALID_PARAM, "command line empty. Try -h for usages.\n"); | |
| HYDU_ERR_SETANDJUMP(status, HYD_INVALID_PARAM, "No executable provided. Try -h for usage.\n"); |
Check empty command line and fail early rather than resulting in mysterious seg faults.
raffenet
approved these changes
May 15, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Check empty command line and fail early rather than resulting in mysterious seg faults.
Fixes #6519
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.