Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: implement multiplex stream comm #5946

Merged
merged 10 commits into from
May 2, 2022

Conversation

hzhou
Copy link
Contributor

@hzhou hzhou commented Apr 15, 2022

Pull Request Description

Implement --

  • MPIX_Stream_comm_create_multiplex
  • MPIX_Stream_send
  • MPIX_Stream_recv

Depend on:

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@hzhou hzhou changed the title stream: implement pt2pt stream APIs stream: implement multiplex stream comm Apr 16, 2022
@hzhou hzhou force-pushed the 2204_stream_multiplex branch 10 times, most recently from 8403271 to 80cbd1f Compare April 20, 2022 14:57
@hzhou
Copy link
Contributor Author

hzhou commented Apr 20, 2022

test:mpich/ch4/most
test:mpich/ch3/most

@hzhou hzhou marked this pull request as ready for review April 20, 2022 14:59
@hzhou hzhou force-pushed the 2204_stream_multiplex branch 3 times, most recently from 6a9af63 to cefa69a Compare April 20, 2022 19:13
@hzhou hzhou force-pushed the 2204_stream_multiplex branch from cefa69a to eddfab3 Compare April 20, 2022 22:24
@hzhou
Copy link
Contributor Author

hzhou commented Apr 20, 2022

test:mpich/ch4/most
test:mpich/ch3/most

@hzhou
Copy link
Contributor Author

hzhou commented Apr 21, 2022

test:mpich/ch3/tcp

@hzhou
Copy link
Contributor Author

hzhou commented Apr 26, 2022

test:mpich/ch4/most
test:mpich/ch3/most

Peculiar failures:

Failed to build allocmemf; make[1]: Entering directory `/var/lib/jenkins-slave/workspace/mpich-review-ch4-ofi/jenkins_configure/asan/label/centos64_review/test/mpi/f77/ext'
make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
  F77      allocmemf.o
allocmemf.f:40:0:

   40 |         end
      | 
Fatal Error: error writing to /tmp/ccWTFj0Q.s: No space left on device
compilation terminated.

Why only allocmemf and allocmemf90?

@hzhou
Copy link
Contributor Author

hzhou commented Apr 27, 2022

test:mpich/ch4/most

@hzhou hzhou requested a review from raffenet April 27, 2022 13:07
@hzhou hzhou force-pushed the 2204_stream_multiplex branch 2 times, most recently from d531d5a to 78af0d8 Compare April 27, 2022 23:13
@hzhou
Copy link
Contributor Author

hzhou commented Apr 27, 2022

test:mpich/ch4/most
test:mpich/ch3/most

ch3 failures https://jenkins-pmrs.cels.anl.gov/job/mpich-review-ch3-sock/1441/

@hzhou hzhou force-pushed the 2204_stream_multiplex branch 2 times, most recently from 2f76dd2 to 954fbb6 Compare April 28, 2022 04:44
@hzhou
Copy link
Contributor Author

hzhou commented Apr 28, 2022

test:mpich/ch4/most
test:mpich/ch3/most

hzhou added 10 commits April 29, 2022 23:00
Define specific macros so we can have tests specific to certain netmod.
When MPICH_CH4_OFI is not define, the test reduce to a dummy test.
Some tests are skipped by checking configure macros. Let runtests to
recognize special output "Test Skipped" so we can tell from test report
whether a test is skipped or actually ran.
We special treated the REQUEST array and STATUS array in the binding
scripts, now we are paying the price.
Each process has multiple streams associated with a multiplex stream
communicator.
This is a utility routine to support pt2pt apis on stream multiplex
communicator.
Add --
  * MPIX_Stream_send
  * MPIX_Stream_isend
  * MPIX_Stream_recv
  * MPIX_Stream_irecv
It tests MPIX_Stream_comm_create_multiplex, MPIX_Stream_send,
MPIX_Stream_recv, MPIX_Stream_isend, MPIX_Stream_irecv.
@hzhou hzhou force-pushed the 2204_stream_multiplex branch from 954fbb6 to 221285f Compare April 30, 2022 04:00
@hzhou
Copy link
Contributor Author

hzhou commented Apr 30, 2022

test:mpich/ch4/most
test:mpich/ch3/most

@hzhou hzhou merged commit 650ca82 into pmodels:main May 2, 2022
@hzhou hzhou deleted the 2204_stream_multiplex branch November 27, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants