mpix: gpu stream aware extensions #5905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2203_stream
branch
2 times, most recently
from
c9ebfa2 to
f84418c
Compare
|
cc @jdinan |
7 tasks
We only implemented the cuda version for now, which simply calls cudaLaunchHostFunc.
Add MPIR_Typerep_pack_stream and MPIR_Typerep_unpack_stream as wrappers for yaksa_pack_stream and yaksa_unpack_stream.
In the stream callback function we can't use gpu APIs reliably, use MPIR_Typerep_pack_stream and MPIR_Typerep_unpack_stream so the callback function only access CPU communications.
If the buffer isn't device buffer, we can directly enqueue the send/recv operations. This can later extend to cases when lower layer can handle GPU communications inside host function callbacks.
|
test:mpich/ch4/gpu/ofi |
|
test:mpich/ch4/gpu/ofi |
|
Close in favor of stream extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add
MPIX_Send_streamMPIX_Send_enqueue andMPIX_Recv_streamMPIX_Recv_enqueue.NOTE: This PR works for the attached test code. But it will not work in general because it doesn't separate traffic. When we invoke progress from an enqueued stream, the progress my invoke operations from non-stream traffic, which may use the GPU, and, e.g. CUDA, will error out.
Reference discussions on
MPIX_Stream: #5908[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.