Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/mpi/io: Check status after zero-byte read #4190

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

raffenet
Copy link
Contributor

@raffenet raffenet commented Nov 22, 2019

Pull Request Description

Until [4b7d553], ROMIO was failing to fill in the status object
for zero-byte operations. See #2332.

Co-authored-by: Jeff Hammond [email protected]

Expected Impact

Author Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Remove xfail from the test suite when fixing a test
  • Commits are self-contained and do not do two things at once
  • Commit message is of the form: module: short description and follows good practice
  • Passes whitespace checkers
  • Passes warning tests
  • Passes all tests
  • Add comments such that someone without knowledge of the code could understand
  • Add Devel Docs in the doc/ directory for any new code design

@raffenet
Copy link
Contributor Author

I stumbled across this when searching through some issues. The test was nearly complete so I figured polish it up and submit.
test:jenkins/ch3/tcp

@raffenet raffenet requested a review from roblatham00 November 22, 2019 19:26
Until [4b7d553], ROMIO was failing to fill in the status object
for zero-byte operations. Add test to confirm the fix. See
pmodels#2332.

Co-authored-by: Jeff Hammond <[email protected]>
@raffenet
Copy link
Contributor Author

test:jenkins/ch3/tcp

Copy link
Contributor

@roblatham00 roblatham00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thanks for adding this.

@raffenet raffenet merged commit b36db8a into pmodels:master Nov 22, 2019
@raffenet raffenet deleted the ticket-2332 branch November 22, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants