chore: pkg.pr.new #2904
chore: pkg.pr.new #2904
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
I think we should add the pkg.pr.new app right now! |
commit: |
.github/workflows/cr.yml
Outdated
| cache: 'pnpm' | ||
| - run: pnpm install | ||
| - run: pnpm build | ||
| - run: pnpm dlx pkg-pr-new publish './dist' --compact --template './examples/*' |
There was a problem hiding this comment.
Can you add a newline at the end?
BTW, we may want a simpler example like examples/counter. examples/demo might be too big for testing.
If you don't have time, let me know so that I can take it.
There was a problem hiding this comment.
There was a problem hiding this comment.
We do have this anyway: pmndrs/jotai#2862
Let's see if @Aslemammad responds in 24 hours.
@sukvvon Would you be interested in creating a simple counter app in examples/counter?
There was a problem hiding this comment.
@dai-shi i knew that counter app is already exist in examples/demo, could you explain your purpose more detail?
There was a problem hiding this comment.
demo has many dependencies for visual effects. for testing purpose with pkg.pr.new, a simpler counter example would be easier.
btw, we also have an issue related with examples in valtio: pmndrs/valtio#1012 help wanted
There was a problem hiding this comment.
feel free to tackle it @sukvvon i'll meanwhile finish this PR reviews and jotai's PR too.
There was a problem hiding this comment.
No problem. I can handle it, but I don't do any styling.
|
This is nice. I didn't like the show toggle. 
|
|
Looks good. 
|
Adding pkg.pr.new to zustand!