Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(middleware): modify both set and setState #2306

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

charkour
Copy link
Collaborator

@charkour charkour commented Jan 21, 2024

Related Issues or Discussions

Related #2305

Summary

Clear up middleware documentation

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Jan 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 1:09pm

Copy link

codesandbox-ci bot commented Jan 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fca6276:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

readme.md Outdated Show resolved Hide resolved
@charkour
Copy link
Collaborator Author

I'll finish this up. Sorry I forgot.

@@ -284,31 +284,6 @@ clearForest()

[Alternatively, there are some other solutions.](./docs/guides/updating-state.md#with-immer)

## Middleware
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dai-shi, is this what you were suggesting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's see how others think. @dbritto-dev @sewera

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm down with you @dai-shi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want dedicated middleware guide, but it should be fine for now. Another issue is typescript.md is rather too big.

@charkour charkour requested a review from dai-shi February 13, 2024 13:09
@dai-shi dai-shi marked this pull request as ready for review February 13, 2024 23:47
@@ -284,31 +284,6 @@ clearForest()

[Alternatively, there are some other solutions.](./docs/guides/updating-state.md#with-immer)

## Middleware
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want dedicated middleware guide, but it should be fine for now. Another issue is typescript.md is rather too big.

@dai-shi dai-shi merged commit eb8443f into pmndrs:main Feb 15, 2024
37 checks passed
@charkour charkour deleted the middleware-docs branch February 15, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants