Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5 #2138

Merged
merged 78 commits into from
Aug 16, 2024
Merged

v5 #2138

merged 78 commits into from
Aug 16, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 22, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 0:34am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 22, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link

github-actions bot commented Oct 22, 2023 •
edited
Loading

Size Change: -48.8 kB (-80.05%) 🏆

Total Size: 12.2 kB

Filename Size Change
./dist/context.js 0 B -789 B (removed) 🏆
./dist/esm/context.js 0 B -608 B (removed) 🏆
./dist/esm/context.mjs 0 B -612 B (removed) 🏆
./dist/esm/index.js 0 B -739 B (removed) 🏆
./dist/esm/index.mjs 64 B -686 B (-91.47%) 🏆
./dist/esm/middleware.js 0 B -3.95 kB (removed) 🏆
./dist/esm/middleware.mjs 3.56 kB -405 B (-10.23%) 👏
./dist/esm/middleware/immer.js 0 B -210 B (removed) 🏆
./dist/esm/react/shallow.js 0 B -464 B (removed) 🏆
./dist/esm/react/shallow.mjs 267 B -197 B (-42.46%) 🎉
./dist/esm/shallow.js 0 B -499 B (removed) 🏆
./dist/esm/shallow.mjs 82 B -426 B (-83.86%) 🏆
./dist/esm/traditional.js 0 B -424 B (removed) 🏆
./dist/esm/traditional.mjs 416 B -8 B (-1.89%)
./dist/esm/vanilla.js 0 B -653 B (removed) 🏆
./dist/esm/vanilla.mjs 403 B -259 B (-39.12%) 🎉
./dist/esm/vanilla/shallow.js 0 B -355 B (removed) 🏆
./dist/esm/vanilla/shallow.mjs 550 B +195 B (+54.93%) 🆘
./dist/index.js 244 B -662 B (-73.07%) 🏆
./dist/middleware.js 3.56 kB -923 B (-20.57%) 🎉
./dist/middleware/immer.js 229 B -99 B (-30.18%) 🎉
./dist/react/shallow.js 282 B -804 B (-74.03%) 🏆
./dist/shallow.js 189 B -944 B (-83.32%) 🏆
./dist/system/context.development.js 0 B -689 B (removed) 🏆
./dist/system/context.production.js 0 B -388 B (removed) 🏆
./dist/system/index.development.js 0 B -918 B (removed) 🏆
./dist/system/index.production.js 0 B -432 B (removed) 🏆
./dist/system/middleware.development.js 0 B -4.09 kB (removed) 🏆
./dist/system/middleware.production.js 0 B -2.66 kB (removed) 🏆
./dist/system/middleware/immer.development.js 0 B -292 B (removed) 🏆
./dist/system/middleware/immer.production.js 0 B -188 B (removed) 🏆
./dist/system/react/shallow.development.js 0 B -564 B (removed) 🏆
./dist/system/react/shallow.production.js 0 B -387 B (removed) 🏆
./dist/system/shallow.development.js 0 B -545 B (removed) 🏆
./dist/system/shallow.production.js 0 B -330 B (removed) 🏆
./dist/system/traditional.development.js 0 B -536 B (removed) 🏆
./dist/system/traditional.production.js 0 B -361 B (removed) 🏆
./dist/system/vanilla.development.js 0 B -694 B (removed) 🏆
./dist/system/vanilla.production.js 0 B -325 B (removed) 🏆
./dist/system/vanilla/shallow.development.js 0 B -427 B (removed) 🏆
./dist/system/vanilla/shallow.production.js 0 B -309 B (removed) 🏆
./dist/traditional.js 430 B -42 B (-8.9%) ✅
./dist/umd/context.development.js 0 B -894 B (removed) 🏆
./dist/umd/context.production.js 0 B -561 B (removed) 🏆
./dist/umd/index.development.js 0 B -1.03 kB (removed) 🏆
./dist/umd/index.production.js 0 B -557 B (removed) 🏆
./dist/umd/middleware.development.js 0 B -4.63 kB (removed) 🏆
./dist/umd/middleware.production.js 0 B -2.99 kB (removed) 🏆
./dist/umd/middleware/immer.development.js 0 B -483 B (removed) 🏆
./dist/umd/middleware/immer.production.js 0 B -341 B (removed) 🏆
./dist/umd/react/shallow.development.js 0 B -1.22 kB (removed) 🏆
./dist/umd/react/shallow.production.js 0 B -883 B (removed) 🏆
./dist/umd/shallow.development.js 0 B -1.24 kB (removed) 🏆
./dist/umd/shallow.production.js 0 B -874 B (removed) 🏆
./dist/umd/traditional.development.js 0 B -650 B (removed) 🏆
./dist/umd/traditional.production.js 0 B -464 B (removed) 🏆
./dist/umd/vanilla.development.js 0 B -828 B (removed) 🏆
./dist/umd/vanilla.production.js 0 B -426 B (removed) 🏆
./dist/umd/vanilla/shallow.development.js 0 B -1.12 kB (removed) 🏆
./dist/umd/vanilla/shallow.production.js 0 B -838 B (removed) 🏆
./dist/vanilla.js 416 B -295 B (-41.49%) 🎉
./dist/vanilla/shallow.js 562 B -421 B (-42.83%) 🎉
./dist/esm/react.mjs 333 B +333 B (new file) 🆕
./dist/react.js 353 B +353 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./dist/esm/middleware/immer.mjs 210 B

compressed-size-action

@sewera
Copy link
Collaborator

sewera commented Oct 22, 2023

Maybe consider changing React Snowpack to React Vite on CodeSandbox?

@dai-shi
Copy link
Member Author

dai-shi commented Oct 22, 2023

I think you can just add it, if you are talking about .codesandbox/ci.json.
Feel free to open a PR to the main branch.
I don't know if the container sandbox is already supported.

@sewera
Copy link
Collaborator

sewera commented Oct 22, 2023

I'll see if I've got some time in the nearest future :)

@TheMikeyRoss
Copy link

I'm a noob learning things and asking around.

I noticed many libraries dropping default exports. may I ask why?

@dai-shi
Copy link
Member Author

dai-shi commented Nov 22, 2023

@TheMikeyRoss Can you open a new discussion? https://github.com/pmndrs/zustand/discussions/new

@charkour
Copy link
Collaborator

charkour commented Dec 9, 2023

@dai-shi, I see the checklist in the PR description, could I help tackle some of the bullet points? Thanks

@dai-shi
Copy link
Member Author

dai-shi commented Dec 9, 2023

@charkour I was wondering when we should start this, but if you are interested please go ahead. Note that I may have some hidden requirements which isn't described well in the bullet points, so bear with me. (I think I should work on the TS one on my own.)

We do something like this pmndrs/valtio#810, so please open PRs for each point against v5 branch.

@charkour
Copy link
Collaborator

charkour commented Dec 9, 2023

Sounds great! I can start on dropping the default exports.

No worries on the hidden requirements, I'm happy to help and let you take over if you disagree with one of my changes.

This was referenced Dec 9, 2023
Merged
Merged
Merged
Merged
@charkour
[v5] breaking: drop default exports (#2238)
8030aee 
* fix: drop default exports for v5

* chore: remove default from cjs build

* refactor: export shallow in v5

* fix: remove `addModuleExport` option for cjs.
@dai-shi
Copy link
Member Author

dai-shi commented Aug 15, 2024

This is ready for quite a while. Let's merge it and ship v5-rc.

@dai-shi
Copy link
Member Author

dai-shi commented Aug 16, 2024

🎉 Kudos to @charkour who has done most of initial work.

@dai-shi dai-shi merged commit e247220 into main Aug 16, 2024
25 checks passed
@dai-shi dai-shi deleted the v5 branch August 16, 2024 00:41
@charkour
Copy link
Collaborator

Happy to help!

@dbritto-dev
Copy link
Collaborator

Props to @charkour :D

@Evan-2007 Evan-2007 mentioned this pull request Nov 8, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Nov 9, 2024
Open
@welllucky welllucky mentioned this pull request Nov 9, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Nov 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dai-shi @sewera @TheMikeyRoss @charkour @dbritto-dev @DavideSegullo @bluejoyq @onlined @Yonom