Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): do not depend on react in build #358

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Feb 11, 2022

fix #356

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/valtio/BDaXYhJFS6DBWwTDQYsR1GDQssSN
✅ Preview: https://valtio-git-fix-utilsno-react-dependency-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2472a62:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

Size Change: -53 B (0%)

Total Size: 34.4 kB

Filename Size Change
dist/esm/utils.js 3.89 kB -15 B (0%)
dist/system/utils.js 4.13 kB -17 B (0%)
dist/umd/utils.js 4.69 kB -15 B (0%)
dist/utils.js 4.54 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size
dist/esm/index.js 1.36 kB
dist/esm/macro.js 613 B
dist/esm/vanilla.js 1.84 kB
dist/index.js 1.45 kB
dist/macro.js 910 B
dist/system/index.js 1.59 kB
dist/system/macro.js 721 B
dist/system/vanilla.js 1.98 kB
dist/umd/index.js 1.59 kB
dist/umd/macro.js 1.06 kB
dist/umd/vanilla.js 2.1 kB
dist/vanilla.js 1.96 kB

compressed-size-action

@@ -1,4 +1,4 @@
import { proxy } from 'valtio'
import { proxy } from '../vanilla'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I faced this issue with jotai/devtools yesterday, you may consider updating it also!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*in vite

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the issue in jotai? jotai is tightly coupled with react for now. (I want to improve it eventually.)

@dai-shi dai-shi merged commit 8f00b86 into main Feb 12, 2022
@dai-shi dai-shi deleted the fix/utils/no-react-dependency branch February 12, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants