fix: avoid const enum and deprecate DeepResolveType #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #327 (comment)
close #292
AsRef
const enum was introduced in #146 to fix some typing issue with snapshot. But, this causes some trouble while explicitly typing it, without any workarounds.This changes
AsRef
to be hopefully unique type. This allows types to be inferred. While we don't recommend, you can define the sameAsRef
on your end. It was our strong hope to hide the internal type as implementation detail and it's finally possible.DeepResolveType
was exported previously (which is not considered a public api, but someone might have used it), but it's now deprecated.Migration Guide
In case you need to specify snapshot types, there are two options.
Assert mutable (let's lie)
Wrap types with
Readonly<>
If the state is deeply nested, please define
DeepReadonly
type util.Other hacks
Extract the return type of
snapshot