build: use esbuild plugin #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 289b7ce:
|
|
Hi, thanks for your work! Two reasons:
|
Done! I actually think the speed element is the same, but I agree, it's better to have consistent structure between each. |
|
I hope that esbuild can replace babel macro in the future :) |
dai-shi
reviewed
Mar 28, 2021
dai-shi
reviewed
Mar 28, 2021
babel.config.js
Outdated
| @@ -16,6 +16,7 @@ module.exports = (api, targets) => { | |||
| ], | |||
| ], | |||
| plugins: [ | |||
| '@babel/plugin-transform-runtime', | |||
There was a problem hiding this comment.
I might be wrong, but I think we do -> pmndrs/jotai#378 (comment)
I set this as I wanted to get rid of the warning when bundling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I made a PR for jotai a few days ago updating the build tooling to use esbuild as the typescript transpiler and @dai-shi requested I make PRs for zustand and valtio, so here we are! The main reason for this change is because of how much faster esbuild is at compiling javascript from typescript:
Before
✨ Done in 24.54s.
After
✨ Done in 9.38s.
There are also some very minor bundle size changes with this update.
General overview of changes
esbuildandrollup-plugin-esbuildtypescriptplugin increateESMConfigandcreateCommonJSConfigto use esbuildid.includes('@babel/runtime')to the externals check per this recommendationtslibas a dev dependency due to it being missing for the typescript plugin