Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated keyCode in controls #59

Merged
merged 1 commit into from
May 11, 2021

Conversation

haywirez
Copy link
Contributor

@haywirez haywirez commented May 11, 2021

Brings the controls here in three-stdlib closer up to date with three: mrdoob/three.js#21409

Why

What

Checklist

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

Brings three-stdlib up to date with three: mrdoob/three.js#21409
@vercel
Copy link

vercel bot commented May 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/three-stdlib/tLVGd64pGy7FKxkkhbjoyS77AECv
✅ Preview: https://three-stdlib-git-fork-haywirez-controls-keycode-to-key-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 796888a:

Sandbox Source
three-stdlib-ssr Configuration

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! ⭐

@joshuaellis joshuaellis merged commit cf15c71 into pmndrs:main May 11, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants