-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: recognize className
prop to AnimatedComponent
s
#2292
Conversation
🦋 Changeset detectedLatest commit: 17d97ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
className
attribute to AnimatedComponent
sclassName
prop to AnimatedComponent
s
Thank you for the contribution, I do ask you fill out the PR description in detail – it's historical to the project & explains lots around why you've done what you've done etc. A good blog around this can be found here :) https://github.blog/2015-01-21-how-to-write-the-perfect-pull-request/ |
Sorry, I thought linking the issue would be sufficient. fixed. |
@joshuaellis anything I can do to help this get merged? The description's been updated, btw. |
+1 to this |
Hey, sorry for my late repsonse (see status) couple of things:
Doing that will also help me see how it works, but from your current changes, I don't see any reason this should not be merged given we address those two points :) |
This should allow an animated As for running I'm currently off work for the week, so if you still need me to clone the repo and install prettier to format the code, it'll most likely be next Monday. |
69b25ac
to
af657a2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
af657a2
to
e68e3a0
Compare
there you go~ |
Can merge this once the CI passes, thank you for your contribution, truly appreciated! ⭐ |
##### [`v9.7.5](https://github.com/pmndrs/react-spring/releases/tag/v9.7.5) #### What's Changed - fix: recognize `className` prop to `AnimatedComponent`s by [@LoganDark](https://github.com/LoganDark) in pmndrs/react-spring#2292 - fix: update document edit page links by [@anonymousRecords](https://github.com/anonymousRecords) in pmndrs/react-spring#2320 #### New Contributors - [@LoganDark](https://github.com/LoganDark) made their first contribution in pmndrs/react-spring#2292 - [@anonymousRecords](https://github.com/anonymousRecords) made their first contribution in pmndrs/react-spring#2320 **Full Changelog**: pmndrs/react-spring@v9.7.4...v9.7.5
##### [`v9.7.5](https://github.com/pmndrs/react-spring/releases/tag/v9.7.5) #### What's Changed - fix: recognize `className` prop to `AnimatedComponent`s by [@LoganDark](https://github.com/LoganDark) in pmndrs/react-spring#2292 - fix: update document edit page links by [@anonymousRecords](https://github.com/anonymousRecords) in pmndrs/react-spring#2320 #### New Contributors - [@LoganDark](https://github.com/LoganDark) made their first contribution in pmndrs/react-spring#2292 - [@anonymousRecords](https://github.com/anonymousRecords) made their first contribution in pmndrs/react-spring#2320 **Full Changelog**: pmndrs/react-spring@v9.7.4...v9.7.5
Allows the
className
prop of animated components (likeanimated.div
) to be passed aSpringValue
.In the past, attempting to animate this prop would result in a
class-name
attribute being created on the element instead.Fixes #2291
Checklist