Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): imperative and target links in homepage #1998

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

heyfirst
Copy link
Contributor

@heyfirst heyfirst commented Oct 15, 2022

Why

It seems the link buttons in document is broken. Both imperatives and target. Also, it seems target concept document is not introduce yet but I believe it would be under /docs/concept/target for sure.

What

Correct both of incorrect links.

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2022

⚠️ No Changeset found

Latest commit: 1839048

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-spring-io ❌ Failed (Inspect) Oct 15, 2022 at 9:22AM (UTC)

@vercel
Copy link

vercel bot commented Oct 15, 2022

@heyfirst is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1839048:

Sandbox Source
spring-animating-auto Configuration
spring-card Configuration
spring-cards-stack Configuration
spring-chain Configuration
spring-css-keyframes Configuration
spring-draggable-list Configuration
spring-exit-before-enter Configuration
spring-flip-card Configuration
spring-goo-blobs Configuration
spring-image-fade Configuration
spring-list-reordering Configuration
spring-masonry Configuration
spring-multistage-transition Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
initial-rocket Configuration
spring-simple-transition Configuration
spring-svg-filter Configuration
spring-slide Configuration
spring-tree Configuration
spring-viewpager Configuration

@joshuaellis joshuaellis changed the title fix: imperative and target links in homepage fix(docs): imperative and target links in homepage Oct 17, 2022
@joshuaellis joshuaellis merged commit 1eb56af into pmndrs:beta-docs Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants