refactor(vanilla, react): change exported functions to 'function declarations' and non-exported ones to 'arrow functions' #3002
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sukvvon
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/DD986KBRZ |
See documentations for usage instructions.
dai-shi
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Thanks for the suggestion. However, the coding style is slightly different. If you want to make it consistent, please follow this rule:
- for exported functions, use function declaration
- for other functions, use const arrow function (and omit return statements if possible.)
sukvvon
force-pushed
the
refactor/core-arrow-to-function
branch
from
52a86e4 to
20d548a
Compare
sukvvon
changed the title
sukvvon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check List
pnpm run fixfor formatting and linting code and docs