Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update examples #2883

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Fix: update examples #2883

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c62c19b
fix: update readme (examples)
leweyse Dec 20, 2024
a4d2dc0
fix: update relevant dependencies
leweyse Dec 20, 2024
86bce58
Merge branch 'main' into fix/update-examples
dai-shi Dec 22, 2024
8c3ef43
Apply suggestions from code review
dai-shi Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions examples/hacker_news/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Hacker News [![Open in CodeSandbox](https://img.shields.io/badge/Open%20in-CodeSandbox-blue?style=flat-square&logo=codesandbox)](https://githubbox.com/pmndrs/jotai/tree/main/examples/hacker_news)
# Hacker News [![Open in StackBlitz](https://img.shields.io/badge/Open%20in-StackBlitz-blue?style=flat-square&logo=stackblitz)](https://stackblitz.com/github/pmndrs/jotai/tree/main/examples/hacker_news)

## Description

Expand All @@ -10,15 +10,15 @@ Demonstrate a news articles with jotai, hit next to see more articles.
git clone https://github.com/pmndrs/jotai

# install project dependencies & build the library
cd jotai && yarn
cd jotai && pnpm i
dai-shi marked this conversation as resolved.
Show resolved Hide resolved

# move to the examples folder & install dependencies
cd examples/hacker_news && yarn
cd examples/hacker_news && pnpm i
dai-shi marked this conversation as resolved.
Show resolved Hide resolved

# start the dev server
yarn start
pnpm dev
```

## Set up on codesandbox
## Set up on `StackBlitz`

Link: https://githubbox.com/pmndrs/jotai/tree/main/examples/hacker_news
Link: https://stackblitz.com/github/pmndrs/jotai/tree/main/examples/hacker_news
6 changes: 3 additions & 3 deletions examples/hacker_news/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
"dependencies": {
"@react-spring/web": "^9.2.3",
"html-react-parser": "^1.2.6",
"jotai": "^2.0.4",
"jotai": "^2.10.4",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
"devDependencies": {
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"@vitejs/plugin-react": "^4.0.0",
"@vitejs/plugin-react": "^4.3.4",
"typescript": "^5.0.0",
"vite": "^4.0.0"
"vite": "^6.0.5"
}
}
Loading