chore(deps): update dev dependencies #2830
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,6 +27,7 @@ jobs: | |
| - name: Use React 17 for production test | ||
| if: ${{ matrix.env == 'production' }} | ||
| run: | | ||
| pnpm json -I -f package.json -e "this.pnpm.patchedDependencies={};" | ||
| pnpm add -D [email protected] [email protected] @testing-library/[email protected] | ||
| - name: Patch for DEV-ONLY | ||
| if: ${{ matrix.env == 'development' }} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,9 +33,9 @@ jobs: | |
| - 18.1.0 | ||
| - 18.2.0 | ||
| - 18.3.1 | ||
| - 19.0.0-rc.1 | ||
| - 19.0.0-rc-e1ef8c95-20241115 | ||
| - 0.0.0-experimental-e1ef8c95-20241115 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
|
|
@@ -47,7 +47,9 @@ jobs: | |
| - run: pnpm install --frozen-lockfile | ||
| - name: Install legacy testing-library | ||
| if: ${{ startsWith(matrix.react, '16.') || startsWith(matrix.react, '17.') }} | ||
| run: | | ||
| pnpm json -I -f package.json -e "this.pnpm.patchedDependencies={};" | ||
| pnpm add -D @testing-library/[email protected] | ||
| - name: Patch for React 16 | ||
| if: ${{ startsWith(matrix.react, '16.') }} | ||
| run: | | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,6 +91,7 @@ jobs: | |
| - name: Patch testing setup for older TS | ||
| if: ${{ matrix.typescript == '4.0.5' || startsWith(matrix.typescript, '3.') }} | ||
| run: | | ||
| pnpm json -I -f package.json -e "this.pnpm.patchedDependencies={};" | ||
| pnpm add -D @testing-library/[email protected] @testing-library/[email protected] | ||
| rm node_modules/vitest/dist/*.d.ts | ||
| echo "declare module 'vitest'" >> ./src/types.d.ts | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,19 +136,19 @@ | |
| "@types/node": "^22.9.0", | ||
| "@types/react": "^18.3.12", | ||
| "@types/react-dom": "^18.3.1", | ||
| "@typescript-eslint/eslint-plugin": "^8.14.0", | ||
| "@typescript-eslint/parser": "^8.14.0", | ||
| "@vitest/coverage-v8": "^2.1.5", | ||
| "@vitest/eslint-plugin": "^1.1.10", | ||
| "@vitest/ui": "^2.1.5", | ||
| "benny": "^3.7.1", | ||
| "downlevel-dts": "^0.11.0", | ||
| "esbuild": "^0.24.0", | ||
| "eslint": "8.57.0", | ||
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-import-resolver-alias": "^1.1.2", | ||
| "eslint-plugin-import": "^2.31.0", | ||
| "eslint-plugin-jest-dom": "^5.5.0", | ||
| "eslint-plugin-prettier": "^5.2.1", | ||
| "eslint-plugin-react": "^7.37.2", | ||
| "eslint-plugin-react-compiler": "19.0.0-beta-a7bf2bd-20241110", | ||
|
|
@@ -158,17 +158,17 @@ | |
| "jsdom": "^25.0.1", | ||
| "json": "^11.0.0", | ||
| "prettier": "^3.3.3", | ||
| "react": "19.0.0-rc.1", | ||
|
There was a problem hiding this comment. Updating react to rc.1 makes tests to fail. @kretajak I wonder if you are familiar with this case. Do we misuse RTL for async tests? There was a problem hiding this comment. I will take a look at that. The way RTL is used here to test async stuff is fine from my perspective. There was a problem hiding this comment. Looks like broken tests are using There was a problem hiding this comment. Thanks for taking a look. I know the Suspense behavior was changed, but didn't consider if it really broke it. https://stackblitz.com/edit/vitejs-vite-hbi7w9?file=src%2FApp.tsx&terminal=dev This looks like working. So, it's probably test only issue. |
||
| "react-dom": "19.0.0-rc.1", | ||
| "rollup": "^4.27.2", | ||
| "rollup-plugin-banner2": "^1.3.0", | ||
| "rollup-plugin-esbuild": "^6.1.1", | ||
| "rxjs": "^7.8.1", | ||
| "shelljs": "^0.8.5", | ||
| "shx": "^0.3.4", | ||
| "ts-expect": "^1.3.0", | ||
| "typescript": "^5.6.3", | ||
| "vitest": "^2.1.5", | ||
| "wonka": "^6.3.4" | ||
| }, | ||
| "peerDependencies": { | ||
|
|
@@ -182,5 +182,10 @@ | |
| "react": { | ||
| "optional": true | ||
| } | ||
| }, | ||
| "pnpm": { | ||
| "patchedDependencies": { | ||
| "@testing-library/[email protected]": "patches/@[email protected]" | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| diff --git a/dist/pure.js b/dist/pure.js | ||
| index 7b62fa743198d1928e02501cc99f5dd7c230e9a6..757cbc4f46ae9fce59cb770da88ebb34b3daf2af 100644 | ||
| --- a/dist/pure.js | ||
| +++ b/dist/pure.js | ||
| @@ -169,7 +169,7 @@ function createLegacyRoot(container) { | ||
| } | ||
| }; | ||
| } | ||
| -function renderRoot(ui, { | ||
| +async function renderRoot(ui, { | ||
| baseElement, | ||
| container, | ||
| hydrate, | ||
| @@ -177,7 +177,7 @@ function renderRoot(ui, { | ||
| root, | ||
| wrapper: WrapperComponent | ||
| }) { | ||
| - (0, _actCompat.default)(() => { | ||
| + await (0, _actCompat.default)(() => { | ||
|
There was a problem hiding this comment. As it turns out, this helps. |
||
| if (hydrate) { | ||
| root.hydrate(strictModeIfNeeded(wrapUiIfNeeded(ui, WrapperComponent)), container); | ||
| } else { | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the list of commits for the change:
facebook/react@5c56b87...e1ef8c9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More precisely, it's between these commit that cause the error:
facebook/react@380f5d6...b01722d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So,
enableSiblingPrerenderingshould only be the meaningful change.