idea4: atomFamily supports has #2683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/G74U9LZR3 |
See documentations for usage instructions.
dmaskasky
force-pushed
the
atom-family-has
branch
from
6ca03e0 to
ff4f13d
Compare
dmaskasky
changed the title
dmaskasky
force-pushed
the
atom-family-has
branch
from
ff4f13d to
3d21928
Compare
dai-shi
reviewed
Jul 31, 2024
| @@ -4,6 +4,7 @@ type ShouldRemove<Param> = (createdAt: number, param: Param) => boolean | |||
|
|
|||
| export interface AtomFamily<Param, AtomType> { | |||
| (param: Param): AtomType | |||
| has(atom: AtomType): boolean | |||
There was a problem hiding this comment.
Thanks. This is exactly what I imagined including the implementation.
I'm a bit hesitant with this new api, though.
- I don't see other use cases than jotai-scope
- I would like to see another solution "injecting callback" and compare with it
Suggested change
| has(atom: AtomType): boolean | |
| onCreate(callback: (param: Param, atom: AtomType) => void): void | |
| getParams(): Iterator<Param> |
There was a problem hiding this comment.
"injecting callback"
It requires onRemove too.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
idea1: #2678
idea2: #2679
idea3: #2681
Fixes #
jotaijs/jotai-scope#50
Summary
jotai-scope is trying to support scoping atomFamily.
This PR demonstrates one approach in which the atomFamily supports
hasfor O(1) atom lookup.The following pseudo code represents logic that would live in jotai-scope.
Check List
pnpm run prettierfor formatting code and docs