Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): useHydrateAtoms type #2229

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Nov 2, 2023

Just found a tiny issue for precise typing.

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview Nov 2, 2023 3:35am

Copy link

codesandbox-ci bot commented Nov 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05d9824:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

type InferAtoms<T extends Iterable<AtomTuple>> = {
[K in keyof T]: T[K] extends AtomTuple<infer A>
? A extends AnyWritableAtom
? AtomTuple<A, ReturnType<A['read']>>
Copy link
Member Author

@dai-shi dai-shi Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReturnType<A['read']>

is not correct, because it's about "writing".

Copy link

github-actions bot commented Nov 2, 2023

Size Change: 0 B

Total Size: 68.6 kB

ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 907 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.38 kB
dist/index.js 242 B
dist/react.js 1.05 kB
dist/react/utils.js 1.26 kB
dist/system/babel/plugin-debug-label.development.js 1.09 kB
dist/system/babel/plugin-debug-label.production.js 757 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.56 kB
dist/system/babel/preset.production.js 1.13 kB
dist/system/index.development.js 236 B
dist/system/index.production.js 167 B
dist/system/react.development.js 1.17 kB
dist/system/react.production.js 701 B
dist/system/react/utils.development.js 713 B
dist/system/react/utils.production.js 451 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 175 B
dist/system/vanilla.development.js 4.04 kB
dist/system/vanilla.production.js 2 kB
dist/system/vanilla/utils.development.js 4.55 kB
dist/system/vanilla/utils.production.js 2.79 kB
dist/umd/babel/plugin-debug-label.development.js 1.06 kB
dist/umd/babel/plugin-debug-label.production.js 845 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.53 kB
dist/umd/babel/preset.production.js 1.24 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.42 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla.development.js 4.83 kB
dist/umd/vanilla.production.js 2.17 kB
dist/umd/vanilla/utils.development.js 5.33 kB
dist/umd/vanilla/utils.production.js 3.3 kB
dist/utils.js 246 B
dist/vanilla.js 4.75 kB
dist/vanilla/utils.js 5.2 kB

compressed-size-action

@dai-shi dai-shi added this to the v2.5.1 milestone Nov 3, 2023
@dai-shi dai-shi merged commit daa2032 into main Nov 5, 2023
@dai-shi dai-shi deleted the fix/utils/use-hydrate-atoms-type branch November 5, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant