fix(vanilla): Returning the same Promise twice from an atom getter causes Promise chaining cycle. #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4369b53:
|
dai-shi
reviewed
Sep 27, 2023
Co-authored-by: Daishi Kato <[email protected]>
dai-shi
reviewed
Sep 27, 2023
Co-authored-by: Daishi Kato <[email protected]>
|
Tried the CodeSandbox CI build in our project where the bug was initially found, this change fixed the issue. |
dai-shi
approved these changes
Sep 27, 2023
dai-shi
changed the title
|
It was a regression caused by #1933. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
Fixes #2151
Summary
Wrote a unit test reproducing this bug
Checking if the previous promise is different from the next before cancelling it fixes the issue.
Check List
yarn run prettierfor formatting code and docs